Harden WaitsFor timeout test by thomhurst · Pull Request #5926 · thomhurst/TUnit

thomhurst · 2026-05-14T10:20:16Z

Summary

Replace the flaky stopwatch lower-bound check in WaitsFor_Fails_When_Timeout_Expires with assertions on the timeout failure diagnostics.
Avoid asserting retry counts or elapsed time, so the test is not sensitive to OS timer resolution or constrained runner scheduling.
Use a slightly larger named timeout and assert that the diagnostic reports that timeout value.

Tests

dotnet run --project TUnit.Assertions.Tests\TUnit.Assertions.Tests.csproj --configuration Release --framework net10.0 --no-build --treenode-filter "/*/*/WaitsForAssertionTests/*" passed before the final simplification.
Final local rebuild was blocked by local GitVersion/file-lock failures before reaching this test project; CI should verify the pushed branch.

claude

Code Review

Overall: Solid, targeted fix. Replacing a wall-clock lower-bound assertion with a polling-count check is the right approach for removing timer-resolution flakiness.

What works well

Switching from Stopwatch.Elapsed >= 100ms to attempts > 1 removes the OS timer-resolution sensitivity that can fire early on Windows/slow CI environments.
Interlocked.Increment is a good habit even if WaitsFor always polls on the same thread — it's defensive and self-documenting.
Extracting timeout as a named variable and interpolating it into the message assertion ($"...{timeout.TotalMilliseconds:F0}ms") is strictly better than the hardcoded "100ms" — changing the timeout won't silently break the message check.

One thing to consider

attempts > 1 is a very weak lower bound. It proves at least two polls happened, but a hypothetical regression that fires the timeout after only 20 ms (2 polls) would still pass. With timeout = 250ms and pollingInterval = 10ms the expected poll count is ~25.

A CI-safe but tighter alternative that doesn't reintroduce wall-clock fragility:

// Expect at least half the theoretical polls — tolerates slow CI while catching early-exit bugs
var minExpectedAttempts = (int)(timeout.TotalMilliseconds / pollingInterval.TotalMilliseconds) / 2;
await Assert.That(attempts).IsGreaterThanOrEqualTo(minExpectedAttempts);

This would assert >= 12 here, which is still very achievable on any real hardware while giving meaningful coverage.

That said, even > 1 combined with the AssertionException throw and the message content check gives reasonable coverage of the intent, so this is not a blocker — just worth thinking about if the goal is to prove the full timeout was exercised, not just that polling started.

Nit

The jump from 100 ms to 250 ms isn't explained in the PR description or a comment. Since the new assertion doesn't rely on wall-clock duration, the 100 ms value would still work. If there's a reason for 250 ms (e.g., making the > 1 assertion more reliable on particularly slow runners), a one-liner comment would be useful.

No blocking issues. The fix is correct and the direction is right.

claude · 2026-05-14T10:21:56Z

Code Review

Overall: Solid, targeted fix. Replacing a wall-clock lower-bound assertion with a polling-count check is the right approach for removing timer-resolution flakiness.

What works well

Switching from Stopwatch.Elapsed >= 100ms to attempts > 1 removes the OS timer-resolution sensitivity that can fire early on Windows/slow CI environments.
Interlocked.Increment is a good habit even if WaitsFor always polls on the same thread — it is defensive and self-documenting.
Extracting timeout as a named variable and interpolating it into the message assertion ($"...{timeout.TotalMilliseconds:F0}ms") is strictly better than the hardcoded "100ms" — changing the timeout value won't silently break the message check.

One thing to consider

attempts > 1 is a very weak lower bound. It proves at least two polls happened, but a hypothetical regression that fires the timeout after only 20 ms (2 polls) would still pass. With timeout = 250ms and pollingInterval = 10ms the expected poll count is ~25.

A CI-safe but tighter alternative that doesn't reintroduce wall-clock fragility:

// Expect at least half the theoretical polls — tolerates slow CI while catching early-exit bugs
var minExpectedAttempts = (int)(timeout.TotalMilliseconds / pollingInterval.TotalMilliseconds) / 2;
await Assert.That(attempts).IsGreaterThanOrEqualTo(minExpectedAttempts);

This would assert >= 12 here, which is still very achievable on any real hardware while giving meaningful coverage of the full timeout duration.

That said, even > 1 combined with the AssertionException throw and the message content check gives reasonable coverage of the intent, so this is not a blocker — just worth thinking about if the goal is to prove the full timeout was exercised.

Nit

The jump from 100 ms to 250 ms isn't explained in the PR description or a comment. Since the new assertion doesn't rely on wall-clock duration, the 100 ms value would still work. If there's a reason for 250 ms (e.g., extra breathing room for slow runners), a one-liner comment would help.

No blocking issues. The fix is correct and the direction is right.

codacy-production · 2026-05-14T10:22:31Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results

Complexity 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

claude

Updated Review (second commit: `3de91710`)

Following up on my earlier review (which covered the first commit that used Interlocked.Increment + attempts > 1): the second commit simplifies further by dropping the poll-count assertion entirely and reverting to a plain value = 1. Here is my assessment of the current state.

What changed and why it matters

The first commit replaced the flaky Stopwatch.Elapsed >= 100ms check with a counter-based proof of polling. My review flagged that attempts > 1 was a weak lower bound. The author's response was to remove the poll-count assertion altogether rather than tighten it — a valid and defensible call.

Current assertions:

An AssertionException is thrown → proves the timeout mechanism fires
Message contains "assertion did not pass within 250ms" → proves diagnostics report the correct value (and this matches the implementation's {_timeout.TotalMilliseconds:F0}ms format on line 92 of WaitsForAssertion.cs exactly)
Message contains "Last error:" → proves the last assertion error is surfaced

Remaining observation from my prior review

The jump from 100 ms to 250 ms is still unexplained. Since the test no longer relies on wall-clock duration at all, the original 100 ms would have worked just as well. If the intent is to give slow CI runners more slack for other reasons (e.g., the exception-construction path), a brief comment would help future readers. Not a blocker.

Overall

The current state is clean, deterministic, and directly tied to observable behavior rather than implementation internals. The test is strictly better than what it replaces. Approved.

Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.40.5 to 1.45.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.45.0  ## What's Changed ### Other Changes * fix(generator): place CallerArgumentExpression before params in [GenerateAssertion] emit by @JohnVerheij in thomhurst/TUnit#5940 * fix(sourcegen): drop covariant TActual when [GenerateAssertion] method has its own type parameters by @JohnVerheij in thomhurst/TUnit#5935 * feat(assertions): add CancellationToken overload to WaitsFor and Eventually by @JohnVerheij in thomhurst/TUnit#5938 * fix(html-report): extract categories using MTP Key=name convention by @thomhurst in thomhurst/TUnit#5946 * feat(html-report): rewrite as split-pane design template by @thomhurst in thomhurst/TUnit#5947 ### Dependencies * chore(deps): update microsoft.testing to 2.2.3 by @thomhurst in thomhurst/TUnit#5927 * chore(deps): update mstest to 4.2.3 by @thomhurst in thomhurst/TUnit#5928 * chore(deps): update tunit to 1.44.39 by @thomhurst in thomhurst/TUnit#5929 * chore(deps): update aspire to 13.3.3 by @thomhurst in thomhurst/TUnit#5933 * chore(deps): update dependency dompurify to v3.4.4 by @thomhurst in thomhurst/TUnit#5944 * chore(deps): update dependency qs to v6.15.2 by @thomhurst in thomhurst/TUnit#5941 **Full Changelog**: thomhurst/TUnit@v1.44.39...v1.45.0 ## 1.44.39  ## What's Changed ### Other Changes * fix(tests): retry trx read to dodge MTP post-exit flush race on Windows by @thomhurst in thomhurst/TUnit#5888 * fix(pipeline): timeout + retry InstallPlaywrightModule so a hung download fails fast by @thomhurst in thomhurst/TUnit#5889 * fix(otel): require two consecutive idle windows in DrainAsync to catch in-transit POSTs by @thomhurst in thomhurst/TUnit#5890 * test(assertions): drop flaky wall-clock upper bound on WaitsFor timeout test by @thomhurst in thomhurst/TUnit#5886 * fix(sourcegen): drop spurious ')' in MethodAssertionGenerator Task<bool> emit by @JohnVerheij in thomhurst/TUnit#5920 * fix(sourcegen): merge generic parameter lists in [AssertionExtension] emit by @JohnVerheij in thomhurst/TUnit#5921 * fix(aspnetcore): scope correlation processor per-factory to stop cross-factory tag leak by @thomhurst in thomhurst/TUnit#5891 * Changed FSharp.Core version to 10.1.300 by @licon4812 in thomhurst/TUnit#5909 * feat(mocks): add Mock.HttpClientFactory() helper by @thomhurst in thomhurst/TUnit#5894 * Harden WaitsFor timeout test by @thomhurst in thomhurst/TUnit#5926 * fix(sourcegen): emit `default` literal for value-type assertion parameters by @JohnVerheij in thomhurst/TUnit#5919 ### Dependencies * chore(deps): update dependency nunit to 4.6.0 by @thomhurst in thomhurst/TUnit#5826 * chore(deps): update tunit to 1.44.0 by @thomhurst in thomhurst/TUnit#5882 * chore(deps): update dependency mockolate to 3.2.0 by @thomhurst in thomhurst/TUnit#5892 * chore(deps): update dependency yaml to v2.9.0 by @thomhurst in thomhurst/TUnit#5887 * chore(deps): update dependency nuget.protocol to 7.6.0 by @thomhurst in thomhurst/TUnit#5897 * chore(deps): update dependency microsoft.entityframeworkcore to 10.0.8 by @thomhurst in thomhurst/TUnit#5898 * chore(deps): update dependency microsoft.templateengine.authoring.cli to v10.0.300 by @thomhurst in thomhurst/TUnit#5899 * chore(deps): update microsoft.extensions by @thomhurst in thomhurst/TUnit#5905 * chore(deps): update microsoft.aspnetcore to 10.0.8 by @thomhurst in thomhurst/TUnit#5904 * chore(deps): update dependency microsoft.templateengine.authoring.templateverifier to 10.0.300 by @thomhurst in thomhurst/TUnit#5902 * chore(deps): update aspire to 13.3.1 by @thomhurst in thomhurst/TUnit#5900 * chore(deps): update dependency system.commandline to 2.0.8 by @thomhurst in thomhurst/TUnit#5903 * chore(deps): update dependency azure.storage.blobs to 12.28.0 by @thomhurst in thomhurst/TUnit#5910 * chore(deps): update dependency dotnet-sdk to v10.0.300 by @thomhurst in thomhurst/TUnit#5901 * chore(deps): update dependency stackexchange.redis to 2.13.1 by @thomhurst in thomhurst/TUnit#5906 * chore(deps): update aspire to 13.3.2 by @thomhurst in thomhurst/TUnit#5924 * chore(deps): bump mermaid from 11.12.2 to 11.15.0 in /docs by @dependabot[bot] in thomhurst/TUnit#5893 * chore(deps): update dependency streamjsonrpc to 2.24.92 by @thomhurst in thomhurst/TUnit#5915 * chore(deps): update dependency dompurify to v3.4.3 by @thomhurst in thomhurst/TUnit#5913 * chore(deps): update microsoft.build to 18.6.3 by @thomhurst in thomhurst/TUnit#5914 **Full Changelog**: thomhurst/TUnit@v1.44.0...v1.44.39 ## 1.44.0  ## What's Changed ### Other Changes * Generated mocks live in the same namespace as the mocked type by @thomhurst in thomhurst/TUnit#5870 * Show multi-step test spans in class timeline, align report ordering with execution, and correlate linked OTel activities by @Copilot in thomhurst/TUnit#5847 * fix: don't leak RUC onto Should-style comparer overloads (#5857) by @thomhurst in thomhurst/TUnit#5873 * Fix culture-dependent timestamp in HTML test report (#5868) by @thomhurst in thomhurst/TUnit#5872 * fix(mocks-http): auto-prepend `/` to partial endpoint paths (#5838) by @thomhurst in thomhurst/TUnit#5874 * Replace Report.ExpandClassTimeline with [ClassTimeline] attribute by @thomhurst in thomhurst/TUnit#5875 * feat(assertions): make ShouldAssertion<T> implement IAssertion (#5824) by @thomhurst in thomhurst/TUnit#5876 * feat(mocks): support non-span ref struct out/ref params by @thomhurst in thomhurst/TUnit#5878 * fix(core): fill optional params when invoking MethodDataSource via reflection by @thomhurst in thomhurst/TUnit#5880 * Mocks: structural fix for Mock<T> / mocked-member name collisions by @thomhurst in thomhurst/TUnit#5881 * chore(mocks): promote TUnit.Mocks packages to stable by @thomhurst in thomhurst/TUnit#5877 ### Dependencies * chore(deps): update tunit to 1.43.41 by @thomhurst in thomhurst/TUnit#5863 * chore(deps): update dependency tunit.assertions.fsharp to 1.43.41 by @thomhurst in thomhurst/TUnit#5865 * chore(deps): bump @babel/plugin-transform-modules-systemjs from 7.28.5 to 7.29.4 in /docs by @dependabot[bot] in thomhurst/TUnit#5867 * chore(deps): bump fast-uri from 3.1.0 to 3.1.2 in /docs by @dependabot[bot] in thomhurst/TUnit#5862 **Full Changelog**: thomhurst/TUnit@v1.43.41...v1.44.0 ## 1.43.41  ## What's Changed ### Other Changes * feat(playwright): expose default Context/Launch options on settings by @thomhurst in thomhurst/TUnit#5861 * fix(hooks): resolve TestDiscovery hook context type by attribute kind, not method name by @thomhurst in thomhurst/TUnit#5860 ### Dependencies * chore(deps): update tunit to 1.43.38 by @thomhurst in thomhurst/TUnit#5858 **Full Changelog**: thomhurst/TUnit@v1.43.38...v1.43.41 ## 1.43.38  ## What's Changed ### Other Changes * feat(playwright): add TUnitPlaywrightSettings defaults by @thomhurst in thomhurst/TUnit#5859 **Full Changelog**: thomhurst/TUnit@v1.43.37...v1.43.38 ## 1.43.37  ## What's Changed ### Other Changes * docs: clarify MethodDataSourceAttribute.Factory is source-generator-managed by @Copilot in thomhurst/TUnit#5835 * fix(assertions): skip ref-struct members in IsEquivalentTo (#5841) by @thomhurst in thomhurst/TUnit#5842 * feat(playwright): add composition-based fixtures by @thomhurst in thomhurst/TUnit#5840 ### Dependencies * chore(deps): update tunit to 1.43.11 by @thomhurst in thomhurst/TUnit#5821 * chore(deps): update dependency polyfill to 10.4.0 by @thomhurst in thomhurst/TUnit#5830 * chore(deps): update dependency polyfill to 10.4.0 by @thomhurst in thomhurst/TUnit#5829 * chore(deps): update react to ^19.2.6 by @thomhurst in thomhurst/TUnit#5839 * chore(deps): update dependency polyfill to 10.5.0 by @thomhurst in thomhurst/TUnit#5848 * chore(deps): update dependency polyfill to 10.5.0 by @thomhurst in thomhurst/TUnit#5849 * chore(deps): update aspire to 13.3.0 by @thomhurst in thomhurst/TUnit#5851 * chore(deps): update dependency brace-expansion to v5.0.6 by @thomhurst in thomhurst/TUnit#5853 * chore(deps): update dependency polyfill to 10.5.1 by @thomhurst in thomhurst/TUnit#5854 * chore(deps): update dependency polyfill to 10.5.1 by @thomhurst in thomhurst/TUnit#5855 * chore(deps): update verify to 31.16.3 by @thomhurst in thomhurst/TUnit#5856 **Full Changelog**: thomhurst/TUnit@v1.43.11...v1.43.37 ## 1.43.11  ## What's Changed ### Other Changes * perf(engine): skip execution ledger for independent tests by @thomhurst in thomhurst/TUnit#5813 * perf(engine): skip tracked object graph rediscovery by @thomhurst in thomhurst/TUnit#5814 * fix: suppress XML doc warnings in generated sources by @mvanhorn in thomhurst/TUnit#5797 * Fix xUnit Throws migration docs by @thomhurst in thomhurst/TUnit#5819 * Fix Should optional overload generation by @thomhurst in thomhurst/TUnit#5820 ### Dependencies * chore(deps): update dependency mockolate to 3.1.0 by @thomhurst in thomhurst/TUnit#5811 * chore(deps): update tunit to 1.43.2 by @thomhurst in thomhurst/TUnit#5809 * chore(deps): update dependency nunit.analyzers to 4.13.0 by @thomhurst in thomhurst/TUnit#5815 * chore(deps): update dependency yaml to v2.8.4 by @thomhurst in thomhurst/TUnit#5812 ## New Contributors * @mvanhorn made their first contribution in thomhurst/TUnit#5797 **Full Changelog**: thomhurst/TUnit@v1.43.2...v1.43.11 ## 1.43.2  ## What's Changed ### Other Changes * fix(assertions): emit auto-generated header in MethodAssertionGenerator output by @JohnVerheij in thomhurst/TUnit#5796 * fix(engine): enforce runtime exclusion for global [NotInParallel] (#5800) by @thomhurst in thomhurst/TUnit#5805 * feat(mocks): add Arg.AnyArgs() shortcut for setup/verify by @thomhurst in thomhurst/TUnit#5792 * fix(should): add specialized assertion sources by @thomhurst in thomhurst/TUnit#5806 ### Dependencies * chore(deps): update tunit to 1.41.0 by @thomhurst in thomhurst/TUnit#5789 * chore(deps): update microsoft.testing to 2.2.2 by @thomhurst in thomhurst/TUnit#5793 * chore(deps): update mstest to 4.2.2 by @thomhurst in thomhurst/TUnit#5794 * chore(deps): update docusaurus by @thomhurst in thomhurst/TUnit#5798 * chore(deps): update dependency dompurify to v3.4.2 by @thomhurst in thomhurst/TUnit#5799 * chore(deps): update dependency mockolate to v3 by @thomhurst in thomhurst/TUnit#5801 **Full Changelog**: thomhurst/TUnit@v1.41.0...v1.43.2 ## 1.41.0  ## TUnit Should() Assertions (beta) This versions comes with a beta version of TUnit.Assertions.Should - meaning that you can do: `myCode.Should().BeEqualTo(fluentShouldSyntax);` For more information see the docs: https://tunit.dev/docs/assertions/should-syntax ## What's Changed ### Other Changes * fix(reporters): unwrap TestFailedException for failure grouping by @thomhurst in thomhurst/TUnit#5776 * Fix item-at Satisfies source typing by @thomhurst in thomhurst/TUnit#5764 * ci(docs): add link-check automation and tighten Docusaurus strictness by @thomhurst in thomhurst/TUnit#5779 * feat: add TUnit.Assertions.Should package by @thomhurst in thomhurst/TUnit#5785 ### Dependencies * chore(deps): update tunit to 1.40.10 by @thomhurst in thomhurst/TUnit#5775 * chore(deps): update actions/cache action to v5 by @thomhurst in thomhurst/TUnit#5780 * chore(deps): update dependency microsoft.net.test.sdk to 18.5.1 by @thomhurst in thomhurst/TUnit#5784 **Full Changelog**: thomhurst/TUnit@v1.40.10...v1.41.0 ## 1.40.10  ## What's Changed ### Other Changes * refactor(opentelemetry): depend on TUnit.Core instead of umbrella TUnit by @thomhurst in thomhurst/TUnit#5774 ### Dependencies * chore(deps): update tunit to 1.40.5 by @thomhurst in thomhurst/TUnit#5769 **Full Changelog**: thomhurst/TUnit@v1.40.5...v1.40.10 Commits viewable in [compare view](thomhurst/TUnit@v1.40.5...v1.45.0). </details> Updated [TUnit.AspNetCore](https://github.com/thomhurst/TUnit) from 1.40.5 to 1.45.0. <details> <summary>Release notes</summary> _Sourced from [TUnit.AspNetCore's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.45.0  ## What's Changed ### Other Changes * fix(generator): place CallerArgumentExpression before params in [GenerateAssertion] emit by @JohnVerheij in thomhurst/TUnit#5940 * fix(sourcegen): drop covariant TActual when [GenerateAssertion] method has its own type parameters by @JohnVerheij in thomhurst/TUnit#5935 * feat(assertions): add CancellationToken overload to WaitsFor and Eventually by @JohnVerheij in thomhurst/TUnit#5938 * fix(html-report): extract categories using MTP Key=name convention by @thomhurst in thomhurst/TUnit#5946 * feat(html-report): rewrite as split-pane design template by @thomhurst in thomhurst/TUnit#5947 ### Dependencies * chore(deps): update microsoft.testing to 2.2.3 by @thomhurst in thomhurst/TUnit#5927 * chore(deps): update mstest to 4.2.3 by @thomhurst in thomhurst/TUnit#5928 * chore(deps): update tunit to 1.44.39 by @thomhurst in thomhurst/TUnit#5929 * chore(deps): update aspire to 13.3.3 by @thomhurst in thomhurst/TUnit#5933 * chore(deps): update dependency dompurify to v3.4.4 by @thomhurst in thomhurst/TUnit#5944 * chore(deps): update dependency qs to v6.15.2 by @thomhurst in thomhurst/TUnit#5941 **Full Changelog**: thomhurst/TUnit@v1.44.39...v1.45.0 ## 1.44.39  ## What's Changed ### Other Changes * fix(tests): retry trx read to dodge MTP post-exit flush race on Windows by @thomhurst in thomhurst/TUnit#5888 * fix(pipeline): timeout + retry InstallPlaywrightModule so a hung download fails fast by @thomhurst in thomhurst/TUnit#5889 * fix(otel): require two consecutive idle windows in DrainAsync to catch in-transit POSTs by @thomhurst in thomhurst/TUnit#5890 * test(assertions): drop flaky wall-clock upper bound on WaitsFor timeout test by @thomhurst in thomhurst/TUnit#5886 * fix(sourcegen): drop spurious ')' in MethodAssertionGenerator Task<bool> emit by @JohnVerheij in thomhurst/TUnit#5920 * fix(sourcegen): merge generic parameter lists in [AssertionExtension] emit by @JohnVerheij in thomhurst/TUnit#5921 * fix(aspnetcore): scope correlation processor per-factory to stop cross-factory tag leak by @thomhurst in thomhurst/TUnit#5891 * Changed FSharp.Core version to 10.1.300 by @licon4812 in thomhurst/TUnit#5909 * feat(mocks): add Mock.HttpClientFactory() helper by @thomhurst in thomhurst/TUnit#5894 * Harden WaitsFor timeout test by @thomhurst in thomhurst/TUnit#5926 * fix(sourcegen): emit `default` literal for value-type assertion parameters by @JohnVerheij in thomhurst/TUnit#5919 ### Dependencies * chore(deps): update dependency nunit to 4.6.0 by @thomhurst in thomhurst/TUnit#5826 * chore(deps): update tunit to 1.44.0 by @thomhurst in thomhurst/TUnit#5882 * chore(deps): update dependency mockolate to 3.2.0 by @thomhurst in thomhurst/TUnit#5892 * chore(deps): update dependency yaml to v2.9.0 by @thomhurst in thomhurst/TUnit#5887 * chore(deps): update dependency nuget.protocol to 7.6.0 by @thomhurst in thomhurst/TUnit#5897 * chore(deps): update dependency microsoft.entityframeworkcore to 10.0.8 by @thomhurst in thomhurst/TUnit#5898 * chore(deps): update dependency microsoft.templateengine.authoring.cli to v10.0.300 by @thomhurst in thomhurst/TUnit#5899 * chore(deps): update microsoft.extensions by @thomhurst in thomhurst/TUnit#5905 * chore(deps): update microsoft.aspnetcore to 10.0.8 by @thomhurst in thomhurst/TUnit#5904 * chore(deps): update dependency microsoft.templateengine.authoring.templateverifier to 10.0.300 by @thomhurst in thomhurst/TUnit#5902 * chore(deps): update aspire to 13.3.1 by @thomhurst in thomhurst/TUnit#5900 * chore(deps): update dependency system.commandline to 2.0.8 by @thomhurst in thomhurst/TUnit#5903 * chore(deps): update dependency azure.storage.blobs to 12.28.0 by @thomhurst in thomhurst/TUnit#5910 * chore(deps): update dependency dotnet-sdk to v10.0.300 by @thomhurst in thomhurst/TUnit#5901 * chore(deps): update dependency stackexchange.redis to 2.13.1 by @thomhurst in thomhurst/TUnit#5906 * chore(deps): update aspire to 13.3.2 by @thomhurst in thomhurst/TUnit#5924 * chore(deps): bump mermaid from 11.12.2 to 11.15.0 in /docs by @dependabot[bot] in thomhurst/TUnit#5893 * chore(deps): update dependency streamjsonrpc to 2.24.92 by @thomhurst in thomhurst/TUnit#5915 * chore(deps): update dependency dompurify to v3.4.3 by @thomhurst in thomhurst/TUnit#5913 * chore(deps): update microsoft.build to 18.6.3 by @thomhurst in thomhurst/TUnit#5914 **Full Changelog**: thomhurst/TUnit@v1.44.0...v1.44.39 ## 1.44.0  ## What's Changed ### Other Changes * Generated mocks live in the same namespace as the mocked type by @thomhurst in thomhurst/TUnit#5870 * Show multi-step test spans in class timeline, align report ordering with execution, and correlate linked OTel activities by @Copilot in thomhurst/TUnit#5847 * fix: don't leak RUC onto Should-style comparer overloads (#5857) by @thomhurst in thomhurst/TUnit#5873 * Fix culture-dependent timestamp in HTML test report (#5868) by @thomhurst in thomhurst/TUnit#5872 * fix(mocks-http): auto-prepend `/` to partial endpoint paths (#5838) by @thomhurst in thomhurst/TUnit#5874 * Replace Report.ExpandClassTimeline with [ClassTimeline] attribute by @thomhurst in thomhurst/TUnit#5875 * feat(assertions): make ShouldAssertion<T> implement IAssertion (#5824) by @thomhurst in thomhurst/TUnit#5876 * feat(mocks): support non-span ref struct out/ref params by @thomhurst in thomhurst/TUnit#5878 * fix(core): fill optional params when invoking MethodDataSource via reflection by @thomhurst in thomhurst/TUnit#5880 * Mocks: structural fix for Mock<T> / mocked-member name collisions by @thomhurst in thomhurst/TUnit#5881 * chore(mocks): promote TUnit.Mocks packages to stable by @thomhurst in thomhurst/TUnit#5877 ### Dependencies * chore(deps): update tunit to 1.43.41 by @thomhurst in thomhurst/TUnit#5863 * chore(deps): update dependency tunit.assertions.fsharp to 1.43.41 by @thomhurst in thomhurst/TUnit#5865 * chore(deps): bump @babel/plugin-transform-modules-systemjs from 7.28.5 to 7.29.4 in /docs by @dependabot[bot] in thomhurst/TUnit#5867 * chore(deps): bump fast-uri from 3.1.0 to 3.1.2 in /docs by @dependabot[bot] in thomhurst/TUnit#5862 **Full Changelog**: thomhurst/TUnit@v1.43.41...v1.44.0 ## 1.43.41  ## What's Changed ### Other Changes * feat(playwright): expose default Context/Launch options on settings by @thomhurst in thomhurst/TUnit#5861 * fix(hooks): resolve TestDiscovery hook context type by attribute kind, not method name by @thomhurst in thomhurst/TUnit#5860 ### Dependencies * chore(deps): update tunit to 1.43.38 by @thomhurst in thomhurst/TUnit#5858 **Full Changelog**: thomhurst/TUnit@v1.43.38...v1.43.41 ## 1.43.38  ## What's Changed ### Other Changes * feat(playwright): add TUnitPlaywrightSettings defaults by @thomhurst in thomhurst/TUnit#5859 **Full Changelog**: thomhurst/TUnit@v1.43.37...v1.43.38 ## 1.43.37  ## What's Changed ### Other Changes * docs: clarify MethodDataSourceAttribute.Factory is source-generator-managed by @Copilot in thomhurst/TUnit#5835 * fix(assertions): skip ref-struct members in IsEquivalentTo (#5841) by @thomhurst in thomhurst/TUnit#5842 * feat(playwright): add composition-based fixtures by @thomhurst in thomhurst/TUnit#5840 ### Dependencies * chore(deps): update tunit to 1.43.11 by @thomhurst in thomhurst/TUnit#5821 * chore(deps): update dependency polyfill to 10.4.0 by @thomhurst in thomhurst/TUnit#5830 * chore(deps): update dependency polyfill to 10.4.0 by @thomhurst in thomhurst/TUnit#5829 * chore(deps): update react to ^19.2.6 by @thomhurst in thomhurst/TUnit#5839 * chore(deps): update dependency polyfill to 10.5.0 by @thomhurst in thomhurst/TUnit#5848 * chore(deps): update dependency polyfill to 10.5.0 by @thomhurst in thomhurst/TUnit#5849 * chore(deps): update aspire to 13.3.0 by @thomhurst in thomhurst/TUnit#5851 * chore(deps): update dependency brace-expansion to v5.0.6 by @thomhurst in thomhurst/TUnit#5853 * chore(deps): update dependency polyfill to 10.5.1 by @thomhurst in thomhurst/TUnit#5854 * chore(deps): update dependency polyfill to 10.5.1 by @thomhurst in thomhurst/TUnit#5855 * chore(deps): update verify to 31.16.3 by @thomhurst in thomhurst/TUnit#5856 **Full Changelog**: thomhurst/TUnit@v1.43.11...v1.43.37 ## 1.43.11  ## What's Changed ### Other Changes * perf(engine): skip execution ledger for independent tests by @thomhurst in thomhurst/TUnit#5813 * perf(engine): skip tracked object graph rediscovery by @thomhurst in thomhurst/TUnit#5814 * fix: suppress XML doc warnings in generated sources by @mvanhorn in thomhurst/TUnit#5797 * Fix xUnit Throws migration docs by @thomhurst in thomhurst/TUnit#5819 * Fix Should optional overload generation by @thomhurst in thomhurst/TUnit#5820 ### Dependencies * chore(deps): update dependency mockolate to 3.1.0 by @thomhurst in thomhurst/TUnit#5811 * chore(deps): update tunit to 1.43.2 by @thomhurst in thomhurst/TUnit#5809 * chore(deps): update dependency nunit.analyzers to 4.13.0 by @thomhurst in thomhurst/TUnit#5815 * chore(deps): update dependency yaml to v2.8.4 by @thomhurst in thomhurst/TUnit#5812 ## New Contributors * @mvanhorn made their first contribution in thomhurst/TUnit#5797 **Full Changelog**: thomhurst/TUnit@v1.43.2...v1.43.11 ## 1.43.2  ## What's Changed ### Other Changes * fix(assertions): emit auto-generated header in MethodAssertionGenerator output by @JohnVerheij in thomhurst/TUnit#5796 * fix(engine): enforce runtime exclusion for global [NotInParallel] (#5800) by @thomhurst in thomhurst/TUnit#5805 * feat(mocks): add Arg.AnyArgs() shortcut for setup/verify by @thomhurst in thomhurst/TUnit#5792 * fix(should): add specialized assertion sources by @thomhurst in thomhurst/TUnit#5806 ### Dependencies * chore(deps): update tunit to 1.41.0 by @thomhurst in thomhurst/TUnit#5789 * chore(deps): update microsoft.testing to 2.2.2 by @thomhurst in thomhurst/TUnit#5793 * chore(deps): update mstest to 4.2.2 by @thomhurst in thomhurst/TUnit#5794 * chore(deps): update docusaurus by @thomhurst in thomhurst/TUnit#5798 * chore(deps): update dependency dompurify to v3.4.2 by @thomhurst in thomhurst/TUnit#5799 * chore(deps): update dependency mockolate to v3 by @thomhurst in thomhurst/TUnit#5801 **Full Changelog**: thomhurst/TUnit@v1.41.0...v1.43.2 ## 1.41.0  ## TUnit Should() Assertions (beta) This versions comes with a beta version of TUnit.Assertions.Should - meaning that you can do: `myCode.Should().BeEqualTo(fluentShouldSyntax);` For more information see the docs: https://tunit.dev/docs/assertions/should-syntax ## What's Changed ### Other Changes * fix(reporters): unwrap TestFailedException for failure grouping by @thomhurst in thomhurst/TUnit#5776 * Fix item-at Satisfies source typing by @thomhurst in thomhurst/TUnit#5764 * ci(docs): add link-check automation and tighten Docusaurus strictness by @thomhurst in thomhurst/TUnit#5779 * feat: add TUnit.Assertions.Should package by @thomhurst in thomhurst/TUnit#5785 ### Dependencies * chore(deps): update tunit to 1.40.10 by @thomhurst in thomhurst/TUnit#5775 * chore(deps): update actions/cache action to v5 by @thomhurst in thomhurst/TUnit#5780 * chore(deps): update dependency microsoft.net.test.sdk to 18.5.1 by @thomhurst in thomhurst/TUnit#5784 **Full Changelog**: thomhurst/TUnit@v1.40.10...v1.41.0 ## 1.40.10  ## What's Changed ### Other Changes * refactor(opentelemetry): depend on TUnit.Core instead of umbrella TUnit by @thomhurst in thomhurst/TUnit#5774 ### Dependencies * chore(deps): update tunit to 1.40.5 by @thomhurst in thomhurst/TUnit#5769 **Full Changelog**: thomhurst/TUnit@v1.40.5...v1.40.10 Commits viewable in [compare view](thomhurst/TUnit@v1.40.5...v1.45.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Updated [TUnit.Core](https://github.com/thomhurst/TUnit) from 1.44.0 to 1.45.8. <details> <summary>Release notes</summary> _Sourced from [TUnit.Core's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.45.8  ## What's Changed ### Other Changes * fix(aspire): route CreateHttpClient through IHttpClientFactory by @thomhurst in thomhurst/TUnit#5957 ### Dependencies * chore(deps): update tunit to 1.45.0 by @thomhurst in thomhurst/TUnit#5949 * chore(deps): update dependency dompurify to v3.4.5 by @thomhurst in thomhurst/TUnit#5951 * chore(deps): update dependency microsoft.testing.extensions.codecoverage to 18.7.0 by @thomhurst in thomhurst/TUnit#5953 * chore(deps): update dependency coverlet.collector to 10.0.1 by @thomhurst in thomhurst/TUnit#5952 * chore(deps): update dependency polyfill to 10.6.0 by @thomhurst in thomhurst/TUnit#5955 * chore(deps): update dependency polyfill to 10.6.0 by @thomhurst in thomhurst/TUnit#5954 **Full Changelog**: thomhurst/TUnit@v1.45.0...v1.45.8 ## 1.45.0  ## What's Changed ### Other Changes * fix(generator): place CallerArgumentExpression before params in [GenerateAssertion] emit by @JohnVerheij in thomhurst/TUnit#5940 * fix(sourcegen): drop covariant TActual when [GenerateAssertion] method has its own type parameters by @JohnVerheij in thomhurst/TUnit#5935 * feat(assertions): add CancellationToken overload to WaitsFor and Eventually by @JohnVerheij in thomhurst/TUnit#5938 * fix(html-report): extract categories using MTP Key=name convention by @thomhurst in thomhurst/TUnit#5946 * feat(html-report): rewrite as split-pane design template by @thomhurst in thomhurst/TUnit#5947 ### Dependencies * chore(deps): update microsoft.testing to 2.2.3 by @thomhurst in thomhurst/TUnit#5927 * chore(deps): update mstest to 4.2.3 by @thomhurst in thomhurst/TUnit#5928 * chore(deps): update tunit to 1.44.39 by @thomhurst in thomhurst/TUnit#5929 * chore(deps): update aspire to 13.3.3 by @thomhurst in thomhurst/TUnit#5933 * chore(deps): update dependency dompurify to v3.4.4 by @thomhurst in thomhurst/TUnit#5944 * chore(deps): update dependency qs to v6.15.2 by @thomhurst in thomhurst/TUnit#5941 **Full Changelog**: thomhurst/TUnit@v1.44.39...v1.45.0 ## 1.44.39  ## What's Changed ### Other Changes * fix(tests): retry trx read to dodge MTP post-exit flush race on Windows by @thomhurst in thomhurst/TUnit#5888 * fix(pipeline): timeout + retry InstallPlaywrightModule so a hung download fails fast by @thomhurst in thomhurst/TUnit#5889 * fix(otel): require two consecutive idle windows in DrainAsync to catch in-transit POSTs by @thomhurst in thomhurst/TUnit#5890 * test(assertions): drop flaky wall-clock upper bound on WaitsFor timeout test by @thomhurst in thomhurst/TUnit#5886 * fix(sourcegen): drop spurious ')' in MethodAssertionGenerator Task<bool> emit by @JohnVerheij in thomhurst/TUnit#5920 * fix(sourcegen): merge generic parameter lists in [AssertionExtension] emit by @JohnVerheij in thomhurst/TUnit#5921 * fix(aspnetcore): scope correlation processor per-factory to stop cross-factory tag leak by @thomhurst in thomhurst/TUnit#5891 * Changed FSharp.Core version to 10.1.300 by @licon4812 in thomhurst/TUnit#5909 * feat(mocks): add Mock.HttpClientFactory() helper by @thomhurst in thomhurst/TUnit#5894 * Harden WaitsFor timeout test by @thomhurst in thomhurst/TUnit#5926 * fix(sourcegen): emit `default` literal for value-type assertion parameters by @JohnVerheij in thomhurst/TUnit#5919 ### Dependencies * chore(deps): update dependency nunit to 4.6.0 by @thomhurst in thomhurst/TUnit#5826 * chore(deps): update tunit to 1.44.0 by @thomhurst in thomhurst/TUnit#5882 * chore(deps): update dependency mockolate to 3.2.0 by @thomhurst in thomhurst/TUnit#5892 * chore(deps): update dependency yaml to v2.9.0 by @thomhurst in thomhurst/TUnit#5887 * chore(deps): update dependency nuget.protocol to 7.6.0 by @thomhurst in thomhurst/TUnit#5897 * chore(deps): update dependency microsoft.entityframeworkcore to 10.0.8 by @thomhurst in thomhurst/TUnit#5898 * chore(deps): update dependency microsoft.templateengine.authoring.cli to v10.0.300 by @thomhurst in thomhurst/TUnit#5899 * chore(deps): update microsoft.extensions by @thomhurst in thomhurst/TUnit#5905 * chore(deps): update microsoft.aspnetcore to 10.0.8 by @thomhurst in thomhurst/TUnit#5904 * chore(deps): update dependency microsoft.templateengine.authoring.templateverifier to 10.0.300 by @thomhurst in thomhurst/TUnit#5902 * chore(deps): update aspire to 13.3.1 by @thomhurst in thomhurst/TUnit#5900 * chore(deps): update dependency system.commandline to 2.0.8 by @thomhurst in thomhurst/TUnit#5903 * chore(deps): update dependency azure.storage.blobs to 12.28.0 by @thomhurst in thomhurst/TUnit#5910 * chore(deps): update dependency dotnet-sdk to v10.0.300 by @thomhurst in thomhurst/TUnit#5901 * chore(deps): update dependency stackexchange.redis to 2.13.1 by @thomhurst in thomhurst/TUnit#5906 * chore(deps): update aspire to 13.3.2 by @thomhurst in thomhurst/TUnit#5924 * chore(deps): bump mermaid from 11.12.2 to 11.15.0 in /docs by @dependabot[bot] in thomhurst/TUnit#5893 * chore(deps): update dependency streamjsonrpc to 2.24.92 by @thomhurst in thomhurst/TUnit#5915 * chore(deps): update dependency dompurify to v3.4.3 by @thomhurst in thomhurst/TUnit#5913 * chore(deps): update microsoft.build to 18.6.3 by @thomhurst in thomhurst/TUnit#5914 **Full Changelog**: thomhurst/TUnit@v1.44.0...v1.44.39 Commits viewable in [compare view](thomhurst/TUnit@v1.44.0...v1.45.8). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=TUnit.Core&package-manager=nuget&previous-version=1.44.0&new-version=1.45.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

test(assertions): harden WaitsFor timeout test

3de9171

thomhurst had a problem deploying to Pull Requests May 14, 2026 10:20 — with GitHub Actions Failure

thomhurst had a problem deploying to Pull Requests May 14, 2026 10:20 — with GitHub Actions Error

claude Bot reviewed May 14, 2026

View reviewed changes

test(assertions): avoid WaitsFor retry timing

019c329

thomhurst temporarily deployed to Pull Requests May 14, 2026 10:46 — with GitHub Actions Inactive

claude Bot reviewed May 14, 2026

View reviewed changes

thomhurst merged commit 1d16e88 into main May 14, 2026
14 checks passed

thomhurst deleted the fix/waitsfor-timeout-test-flake branch May 14, 2026 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Harden WaitsFor timeout test#5926

Harden WaitsFor timeout test#5926
thomhurst merged 2 commits into
mainfrom
fix/waitsfor-timeout-test-flake

thomhurst commented May 14, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

claude Bot commented May 14, 2026

Uh oh!

codacy-production Bot commented May 14, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

thomhurst commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Code Review

What works well

One thing to consider

Nit

Uh oh!

claude Bot commented May 14, 2026

Code Review

What works well

One thing to consider

Nit

Uh oh!

codacy-production Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Updated Review (second commit: 3de91710)

What changed and why it matters

Remaining observation from my prior review

Overall

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

thomhurst commented May 14, 2026 •

edited

Loading

codacy-production Bot commented May 14, 2026 •

edited

Loading

Updated Review (second commit: `3de91710`)